From 31a7097cdc9f9f60a7b6576b8bcee7a49a00552c Mon Sep 17 00:00:00 2001 From: Stevan Freeborn <65925598+StevanFreeborn@users.noreply.github.com> Date: Wed, 1 Jan 2025 20:12:26 -0600 Subject: [PATCH] fix: remove model id validation --- src/AnthropicClient/Models/BaseMessageRequest.cs | 6 ------ src/AnthropicClient/Models/MessageRequest.cs | 1 - src/AnthropicClient/Models/StreamMessageRequest.cs | 1 - .../Unit/Models/MessageRequestTests.cs | 4 ++-- .../Unit/Models/StreamMessageRequestTests.cs | 4 ++-- 5 files changed, 4 insertions(+), 12 deletions(-) diff --git a/src/AnthropicClient/Models/BaseMessageRequest.cs b/src/AnthropicClient/Models/BaseMessageRequest.cs index 04ac289..03a4809 100644 --- a/src/AnthropicClient/Models/BaseMessageRequest.cs +++ b/src/AnthropicClient/Models/BaseMessageRequest.cs @@ -126,7 +126,6 @@ public abstract class BaseMessageRequest /// A value indicating whether the message should be streamed. /// The prompt stop sequences. /// The system messages to use for the request. - /// Thrown when the model ID is invalid. /// Thrown when the model or messages is null. /// Thrown when the messages contain no messages. /// Thrown when the max tokens is less than one. @@ -151,11 +150,6 @@ public abstract class BaseMessageRequest ArgumentValidator.ThrowIfNull(model, nameof(model)); ArgumentValidator.ThrowIfNull(messages, nameof(messages)); - if (AnthropicModels.IsValidModel(model) is false) - { - throw new ArgumentException($"Invalid model ID: {model}"); - } - if (messages.Count < 1) { throw new ArgumentException("Messages must contain at least one message"); diff --git a/src/AnthropicClient/Models/MessageRequest.cs b/src/AnthropicClient/Models/MessageRequest.cs index f091dbf..d3f8771 100644 --- a/src/AnthropicClient/Models/MessageRequest.cs +++ b/src/AnthropicClient/Models/MessageRequest.cs @@ -25,7 +25,6 @@ public class MessageRequest : BaseMessageRequest /// The tools to use for the request. /// The prompt stop sequences. /// The system messages to include with the request. - /// Thrown when the model ID is invalid. /// Thrown when the model or messages is null. /// Thrown when the messages contain no messages. /// Thrown when the max tokens is less than one. diff --git a/src/AnthropicClient/Models/StreamMessageRequest.cs b/src/AnthropicClient/Models/StreamMessageRequest.cs index 402075e..f07c952 100644 --- a/src/AnthropicClient/Models/StreamMessageRequest.cs +++ b/src/AnthropicClient/Models/StreamMessageRequest.cs @@ -25,7 +25,6 @@ public class StreamMessageRequest : BaseMessageRequest /// The tools to use for the request. /// The prompt stop sequences. /// The system messages to include with the request. - /// Thrown when the model ID is invalid. /// Thrown when the model or messages is null. /// Thrown when the messages contain no messages. /// Thrown when the max tokens is less than one. diff --git a/tests/AnthropicClient.Tests/Unit/Models/MessageRequestTests.cs b/tests/AnthropicClient.Tests/Unit/Models/MessageRequestTests.cs index 2efd402..2e7e87c 100644 --- a/tests/AnthropicClient.Tests/Unit/Models/MessageRequestTests.cs +++ b/tests/AnthropicClient.Tests/Unit/Models/MessageRequestTests.cs @@ -232,14 +232,14 @@ public class MessageRequestTests : SerializationTest } [Fact] - public void Constructor_WhenCalledAndModelIsInvalid_ItShouldThrowArgumentException() + public void Constructor_WhenCalledAndModelIsInvalid_ItShouldNotThrowException() { var action = () => new MessageRequest( model: "invalid-model", messages: [new()] ); - action.Should().Throw(); + action.Should().NotThrow(); } [Fact] diff --git a/tests/AnthropicClient.Tests/Unit/Models/StreamMessageRequestTests.cs b/tests/AnthropicClient.Tests/Unit/Models/StreamMessageRequestTests.cs index 67ebd1e..e09982f 100644 --- a/tests/AnthropicClient.Tests/Unit/Models/StreamMessageRequestTests.cs +++ b/tests/AnthropicClient.Tests/Unit/Models/StreamMessageRequestTests.cs @@ -85,14 +85,14 @@ public class StreamMessageRequestTests : SerializationTest } [Fact] - public void Constructor_WhenCalledAndModelIsInvalid_ItShouldThrowArgumentException() + public void Constructor_WhenCalledAndModelIsInvalid_ItShouldNotThrowException() { var action = () => new StreamMessageRequest( model: "invalid-model", messages: [new()] ); - action.Should().Throw(); + action.Should().NotThrow(); } [Fact]