From 5d4fb290ba24095ea564cf8a33366dd53ab4ba44 Mon Sep 17 00:00:00 2001 From: Stevan Freeborn <65925598+StevanFreeborn@users.noreply.github.com> Date: Mon, 19 May 2025 15:28:08 -0500 Subject: [PATCH] fix: cleanup based on copilot review comments --- .vscode/settings.json | 9 +++++++++ src/AnthropicClient/AnthropicApiClient.cs | 2 +- src/AnthropicClient/IAnthropicApiClient.cs | 4 ++-- 3 files changed, 12 insertions(+), 3 deletions(-) diff --git a/.vscode/settings.json b/.vscode/settings.json index b2f391d..11a990d 100644 --- a/.vscode/settings.json +++ b/.vscode/settings.json @@ -3,9 +3,18 @@ "dotnet.defaultSolution": "AnthropicClient.sln", "cSpell.words": [ "Browsable", + "buildtransitive", + "contentfiles", + "Docfx", + "globaltool", "haikus", + "Linq", + "msbuild", "nameof", + "reportgenerator", + "reporttypes", "Szalay", + "targetdir", "typeof" ], "dotnet.unitTests.runSettingsPath": "./tests/AnthropicClient.Tests/.runsettings" diff --git a/src/AnthropicClient/AnthropicApiClient.cs b/src/AnthropicClient/AnthropicApiClient.cs index 58f0944..f05f3e6 100644 --- a/src/AnthropicClient/AnthropicApiClient.cs +++ b/src/AnthropicClient/AnthropicApiClient.cs @@ -303,7 +303,7 @@ public class AnthropicApiClient : IAnthropicApiClient return AnthropicResult>.Success(ReadResultsAsync(), anthropicHeaders); - async IAsyncEnumerable ReadResultsAsync([EnumeratorCancellation] CancellationToken ct = default) + async IAsyncEnumerable ReadResultsAsync() { using var responseContent = await response.Content.ReadAsStreamAsync(); using var streamReader = new StreamReader(responseContent); diff --git a/src/AnthropicClient/IAnthropicApiClient.cs b/src/AnthropicClient/IAnthropicApiClient.cs index 7b33bbe..12d98c7 100644 --- a/src/AnthropicClient/IAnthropicApiClient.cs +++ b/src/AnthropicClient/IAnthropicApiClient.cs @@ -88,7 +88,7 @@ public interface IAnthropicApiClient Task> CountMessageTokensAsync(CountMessageTokensRequest request, CancellationToken cancellationToken = default); /// - /// Lists the models asynchronously. + /// Lists the models asynchronously getting a page of models. /// /// The paging request to use for listing the models. /// A token to cancel the asynchronous operation. @@ -96,7 +96,7 @@ public interface IAnthropicApiClient Task>> ListModelsAsync(PagingRequest? request = null, CancellationToken cancellationToken = default); /// - /// Lists the models asynchronously + /// Lists the model asynchronously getting all the pages of models. /// /// The maximum number of models to return in each page. /// A token to cancel the asynchronous operation.