Stevan/anthropic-client
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: remove unnecessary if checks and add test to handle getting null file

Browse Source
This commit is contained in:
Stevan Freeborn
2025-07-14 23:30:02 -05:00
parent 0aaf6e0995
commit ea4c8230bc
2 changed files with 20 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/AnthropicClient/AnthropicApiClient.cs
-32
View File
@@ -385,14 +385,6 @@ public class AnthropicApiClient : IAnthropicApiClient
public async Task<AnthropicResult<AnthropicFile>> CreateFileAsync(CreateFileRequest request, CancellationToken cancellationToken = default)
{
var response = await SendFileRequestAsync(FilesEndpoint, request, cancellationToken);
if (response.IsSuccessStatusCode is false)
{
var content = await response.Content.ReadAsStringAsync();
var error = Deserialize<AnthropicError>(content) ?? new AnthropicError();
return AnthropicResult<AnthropicFile>.Failure(error, new AnthropicHeaders(response.Headers));
}
return await CreateResultAsync<AnthropicFile>(response);
}
@@ -402,14 +394,6 @@ public class AnthropicApiClient : IAnthropicApiClient
var pagingRequest = request ?? new PagingRequest();
var endpoint = $"{FilesEndpoint}?{pagingRequest.ToQueryParameters()}";
var response = await SendRequestAsync(endpoint, cancellationToken: cancellationToken);
if (response.IsSuccessStatusCode is false)
{
var content = await response.Content.ReadAsStringAsync();
var error = Deserialize<AnthropicError>(content) ?? new AnthropicError();
return AnthropicResult<Page<AnthropicFile>>.Failure(error, new AnthropicHeaders(response.Headers));
}
return await CreateResultAsync<Page<AnthropicFile>>(response);
}
@@ -427,14 +411,6 @@ public class AnthropicApiClient : IAnthropicApiClient
{
var endpoint = $"{FilesEndpoint}/{fileId}";
var response = await SendRequestAsync(endpoint, cancellationToken: cancellationToken);
if (response.IsSuccessStatusCode is false)
{
var content = await response.Content.ReadAsStringAsync();
var error = Deserialize<AnthropicError>(content) ?? new AnthropicError();
return AnthropicResult<AnthropicFile>.Failure(error, new AnthropicHeaders(response.Headers));
}
return await CreateResultAsync<AnthropicFile>(response);
}
@@ -460,14 +436,6 @@ public class AnthropicApiClient : IAnthropicApiClient
{
var endpoint = $"{FilesEndpoint}/{fileId}";
var response = await SendRequestAsync(endpoint, HttpMethod.Delete, cancellationToken);
if (response.IsSuccessStatusCode is false)
{
var content = await response.Content.ReadAsStringAsync();
var error = Deserialize<AnthropicError>(content) ?? new AnthropicError();
return AnthropicResult<AnthropicFileDeleteResponse>.Failure(error, new AnthropicHeaders(response.Headers));
}
return await CreateResultAsync<AnthropicFileDeleteResponse>(response);
}
tests/AnthropicClient.Tests/Integration/AnthropicApiClientTests.cs
+20
View File
@@ -2331,6 +2331,26 @@ public class AnthropicApiClientTests : IntegrationTest
result.Error.Error.Should().BeOfType<InvalidRequestError>();
}
[Fact]
public async Task GetFileAsync_WhenCalledAndCanNotDeserializeResponse_ItShouldReturnError()
{
var fileId = "file_013Zva2CMHLNnXjNJJKqJ2EF";
_mockHttpMessageHandler
.WhenGetFileContentRequest(fileId)
.Respond(
HttpStatusCode.BadRequest,
"application/json",
@"null"
);
var result = await Client.GetFileAsync(fileId);
result.IsSuccess.Should().BeFalse();
result.Error.Should().BeOfType<AnthropicError>();
result.Error.Error.Should().BeOfType<ApiError>();
}
[Fact]
public async Task DeleteFileAsync_WhenCalled_ItShouldReturnDeletionResponse()
{