From 32cf48bf36cc58fae07c616447c791681cca0cc1 Mon Sep 17 00:00:00 2001
From: Stevan Freeborn <65925598+StevanFreeborn@users.noreply.github.com>
Date: Fri, 13 Feb 2026 12:10:59 -0600
Subject: [PATCH] refactor(infra,api.tests): fix my null lies

---
 src/FiscalOS.Core/Accounts/Account.cs                | 4 ++--
 src/FiscalOS.Core/Accounts/Institution.cs            | 2 +-
 tests/FiscalOS.API.Tests/Integration/AddTests.cs     | 6 +++---
 tests/FiscalOS.API.Tests/Integration/ConnectTests.cs | 2 +-
 4 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/FiscalOS.Core/Accounts/Account.cs b/src/FiscalOS.Core/Accounts/Account.cs
index 92e63a4..3434ba6 100644
--- a/src/FiscalOS.Core/Accounts/Account.cs
+++ b/src/FiscalOS.Core/Accounts/Account.cs
@@ -4,9 +4,9 @@ public sealed class Account : Entity
 {
   public Guid UserId { get; init; }
   public Guid InstitutionId { get; init; }
-  public Institution Institution { get; init; } = null!;
+  public Institution? Institution { get; init; }
   public string Name { get; init; } = string.Empty;
-  public AccountMetadata Metadata { get; init; } = null!;
+  public AccountMetadata? Metadata { get; init; }
 
   public static Account From(Guid institutionId, string name, AccountMetadata accountMetadata)
   {
diff --git a/src/FiscalOS.Core/Accounts/Institution.cs b/src/FiscalOS.Core/Accounts/Institution.cs
index 85493d9..22472a2 100644
--- a/src/FiscalOS.Core/Accounts/Institution.cs
+++ b/src/FiscalOS.Core/Accounts/Institution.cs
@@ -4,7 +4,7 @@ public sealed class Institution : Entity
 {
   public Guid UserId { get; init; }
   public string Name { get; init; } = string.Empty;
-  public InstitutionMetadata Metadata { get; init; } = null!;
+  public InstitutionMetadata? Metadata { get; init; }
 
   private Institution()
   {
diff --git a/tests/FiscalOS.API.Tests/Integration/AddTests.cs b/tests/FiscalOS.API.Tests/Integration/AddTests.cs
index 063426f..c4d2a97 100644
--- a/tests/FiscalOS.API.Tests/Integration/AddTests.cs
+++ b/tests/FiscalOS.API.Tests/Integration/AddTests.cs
@@ -222,8 +222,8 @@ public class AddTests(TestApi testApi) : IntegrationTest(testApi)
 
     var json = JsonSerializer.Serialize(new
     {
-      plaidInstitutionId = ((PlaidMetadata)institution.Metadata).PlaidId,
-      plaidAccountId = ((PlaidAccountMetadata)account.Metadata).PlaidId,
+      plaidInstitutionId = ((PlaidMetadata)institution.Metadata!).PlaidId,
+      plaidAccountId = ((PlaidAccountMetadata)account.Metadata!).PlaidId,
       plaidAccountName = ((PlaidAccountMetadata)account.Metadata).PlaidName,
     });
     using var content = new StringContent(json, Encoding.UTF8, "application/json");
@@ -270,7 +270,7 @@ public class AddTests(TestApi testApi) : IntegrationTest(testApi)
 
     var json = JsonSerializer.Serialize(new
     {
-      plaidInstitutionId = ((PlaidMetadata)institution.Metadata).PlaidId,
+      plaidInstitutionId = ((PlaidMetadata)institution.Metadata!).PlaidId,
       plaidAccountId = newAccountId,
       plaidAccountName = newAccountName,
     });
diff --git a/tests/FiscalOS.API.Tests/Integration/ConnectTests.cs b/tests/FiscalOS.API.Tests/Integration/ConnectTests.cs
index 4f2edfe..9f5036b 100644
--- a/tests/FiscalOS.API.Tests/Integration/ConnectTests.cs
+++ b/tests/FiscalOS.API.Tests/Integration/ConnectTests.cs
@@ -136,7 +136,7 @@ public class ConnectTests(TestApi testApi) : IntegrationTest(testApi)
     var json = JsonSerializer.Serialize(new
     {
       publicToken = "token",
-      plaidInstitutionId = ((PlaidMetadata)institution.Metadata).PlaidId,
+      plaidInstitutionId = ((PlaidMetadata)institution.Metadata!).PlaidId,
     });
     using var content = new StringContent(json, Encoding.UTF8, "application/json");
     using var request = new HttpRequestMessage(HttpMethod.Post, ConnectUri)