refactor(api): introduce DTOs for institutional account discovery

- Replace raw Plaid entity response with a dedicated Response wrapper
- Map Plaid accounts to AccountDto to decouple API from external SDK
models
- Update integration tests to assert against the new response structure
- Add JsonConstructors to DTO records for reliable deserialization
This commit is contained in:
Stevan Freeborn
2026-02-13 21:32:49 -06:00
parent 5ab75efae9
commit 3321d2791d
3 changed files with 45 additions and 3 deletions
@@ -1,3 +1,5 @@
using FiscalOS.API.Institutions.GetAvailable;
using Institution = FiscalOS.Core.Accounts.Institution;
namespace FiscalOS.API.Tests.Integration.Institutions;
@@ -108,7 +110,7 @@ public class GetAvailableTests(TestApi testApi) : IntegrationTest(testApi)
var response = await Client.SendAsync(request, TestContext.Current.CancellationToken);
(await response.Should().BeJsonContentOfType<List<Account>>(HttpStatusCode.OK))
.Which.Should().BeEquivalentTo(expectedAccounts);
(await response.Should().BeJsonContentOfType<Response>(HttpStatusCode.OK))
.Which.Accounts.Should().BeEquivalentTo(expectedAccounts.Select(AccountDto.FromPlaidAccount));
}
}