From 5da1f1decf4e9d9e065c3bc9417bee348b09d912 Mon Sep 17 00:00:00 2001 From: Stevan Freeborn <65925598+StevanFreeborn@users.noreply.github.com> Date: Thu, 12 Feb 2026 16:18:42 -0600 Subject: [PATCH] refactor(api.tests): check for correct status code first in assertion --- .../Assertions/HttpResponseMessageAssertions.cs | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/FiscalOS.API.Tests/Assertions/HttpResponseMessageAssertions.cs b/tests/FiscalOS.API.Tests/Assertions/HttpResponseMessageAssertions.cs index 48f24d7..abd5b98 100644 --- a/tests/FiscalOS.API.Tests/Assertions/HttpResponseMessageAssertions.cs +++ b/tests/FiscalOS.API.Tests/Assertions/HttpResponseMessageAssertions.cs @@ -78,12 +78,6 @@ internal sealed class HttpResponseMessageAssertions( private async Task ValidateAndDeserialize(HttpStatusCode expectedStatusCode) where T : ProblemDetails { - _chain.ForCondition(Subject.Content.Headers.ContentType?.MediaType is "application/problem+json") - .FailWith( - "Expected response to be application/problem+json, but found {0}", - Subject.Content.Headers.ContentType?.MediaType - ); - _chain.ForCondition(Subject.StatusCode == expectedStatusCode) .FailWith( "Expected response status code to be {0}, but found {1}", @@ -91,6 +85,12 @@ internal sealed class HttpResponseMessageAssertions( Subject.StatusCode ); + _chain.ForCondition(Subject.Content.Headers.ContentType?.MediaType is "application/problem+json") + .FailWith( + "Expected response to be application/problem+json, but found {0}", + Subject.Content.Headers.ContentType?.MediaType + ); + var problem = await Subject.Content.ReadFromJsonAsync(); _chain.ForCondition(problem is not null)