Stevan/fiscalos
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(infra,api.tests): fix my null lies

Browse Source
This commit is contained in:
Stevan Freeborn
2026-02-13 12:33:37 -06:00
parent 14d8d4dd9e
commit ac0681047b
4 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/FiscalOS.Core/Accounts/Account.cs
+2 -2
View File
@@ -4,9 +4,9 @@ public sealed class Account : Entity
{ {
public Guid UserId { get; init; } public Guid UserId { get; init; }
public Guid InstitutionId { get; init; } public Guid InstitutionId { get; init; }
public Institution Institution { get; init; } = null!; public Institution? Institution { get; init; }
public string Name { get; init; } = string.Empty; public string Name { get; init; } = string.Empty;
public AccountMetadata Metadata { get; init; } = null!; public AccountMetadata? Metadata { get; init; }
public static Account From(Guid institutionId, string name, AccountMetadata accountMetadata) public static Account From(Guid institutionId, string name, AccountMetadata accountMetadata)
{ {
src/FiscalOS.Core/Accounts/Institution.cs
+1 -1
View File
@@ -4,7 +4,7 @@ public sealed class Institution : Entity
{ {
public Guid UserId { get; init; } public Guid UserId { get; init; }
public string Name { get; init; } = string.Empty; public string Name { get; init; } = string.Empty;
public InstitutionMetadata Metadata { get; init; } = null!; public InstitutionMetadata? Metadata { get; init; }
private Institution() private Institution()
{ {
tests/FiscalOS.API.Tests/Integration/AddTests.cs
+3 -3
View File
@@ -222,8 +222,8 @@ public class AddTests(TestApi testApi) : IntegrationTest(testApi)
var json = JsonSerializer.Serialize(new var json = JsonSerializer.Serialize(new
{ {
plaidInstitutionId = ((PlaidMetadata)institution.Metadata).PlaidId, plaidInstitutionId = ((PlaidMetadata)institution.Metadata!).PlaidId,
plaidAccountId = ((PlaidAccountMetadata)account.Metadata).PlaidId, plaidAccountId = ((PlaidAccountMetadata)account.Metadata!).PlaidId,
plaidAccountName = ((PlaidAccountMetadata)account.Metadata).PlaidName, plaidAccountName = ((PlaidAccountMetadata)account.Metadata).PlaidName,
}); });
using var content = new StringContent(json, Encoding.UTF8, "application/json"); using var content = new StringContent(json, Encoding.UTF8, "application/json");
@@ -270,7 +270,7 @@ public class AddTests(TestApi testApi) : IntegrationTest(testApi)
var json = JsonSerializer.Serialize(new var json = JsonSerializer.Serialize(new
{ {
plaidInstitutionId = ((PlaidMetadata)institution.Metadata).PlaidId, plaidInstitutionId = ((PlaidMetadata)institution.Metadata!).PlaidId,
plaidAccountId = newAccountId, plaidAccountId = newAccountId,
plaidAccountName = newAccountName, plaidAccountName = newAccountName,
}); });
tests/FiscalOS.API.Tests/Integration/ConnectTests.cs
+1 -1
View File
@@ -136,7 +136,7 @@ public class ConnectTests(TestApi testApi) : IntegrationTest(testApi)
var json = JsonSerializer.Serialize(new var json = JsonSerializer.Serialize(new
{ {
publicToken = "token", publicToken = "token",
plaidInstitutionId = ((PlaidMetadata)institution.Metadata).PlaidId, plaidInstitutionId = ((PlaidMetadata)institution.Metadata!).PlaidId,
}); });
using var content = new StringContent(json, Encoding.UTF8, "application/json"); using var content = new StringContent(json, Encoding.UTF8, "application/json");
using var request = new HttpRequestMessage(HttpMethod.Post, ConnectUri) using var request = new HttpRequestMessage(HttpMethod.Post, ConnectUri)