Stevan/stevanfreeborn.secureconfig
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

perf: replace static shared lock with per-instance lock and async delay

Browse Source
This commit is contained in:
Stevan Freeborn
2026-04-02 20:49:01 -05:00
parent 04041d0401
commit 54abcb672d
1 changed files with 15 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/StevanFreeborn.Extensions.Configuration.Secure/Storage/JsonFileStorageProvider.cs
+15 -12
View File
@@ -7,7 +7,7 @@ namespace StevanFreeborn.Extensions.Configuration.Secure.Storage;
internal sealed class JsonFileStorageProvider : ISecureStorageProvider internal sealed class JsonFileStorageProvider : ISecureStorageProvider
{ {
private static readonly SemaphoreSlim FileLock = new(1, 1); private readonly SemaphoreSlim _fileLock = new(1, 1);
private readonly PhysicalFileProvider? _fileProvider; private readonly PhysicalFileProvider? _fileProvider;
private readonly IDisposable? _changeTokenRegistration; private readonly IDisposable? _changeTokenRegistration;
private readonly JsonStorageOptions _options; private readonly JsonStorageOptions _options;
@@ -31,11 +31,7 @@ internal sealed class JsonFileStorageProvider : ISecureStorageProvider
_changeTokenRegistration = ChangeToken.OnChange( _changeTokenRegistration = ChangeToken.OnChange(
() => _fileProvider.Watch(_options.FileName), () => _fileProvider.Watch(_options.FileName),
() => () => _ = NotifyStorageChangedAsync()
{
Thread.Sleep(250);
StorageChanged?.Invoke(this, EventArgs.Empty);
}
); );
} }
} }
@@ -59,7 +55,7 @@ internal sealed class JsonFileStorageProvider : ISecureStorageProvider
public async Task WriteAsync(string key, string encryptedData, CancellationToken ct = default) public async Task WriteAsync(string key, string encryptedData, CancellationToken ct = default)
{ {
await FileLock.WaitAsync(ct).ConfigureAwait(false); await _fileLock.WaitAsync(ct).ConfigureAwait(false);
try try
{ {
@@ -69,13 +65,13 @@ internal sealed class JsonFileStorageProvider : ISecureStorageProvider
} }
finally finally
{ {
FileLock.Release(); _fileLock.Release();
} }
} }
public async Task<bool> DeleteAsync(string key, CancellationToken ct = default) public async Task<bool> DeleteAsync(string key, CancellationToken ct = default)
{ {
await FileLock.WaitAsync(ct).ConfigureAwait(false); await _fileLock.WaitAsync(ct).ConfigureAwait(false);
try try
{ {
@@ -86,7 +82,7 @@ internal sealed class JsonFileStorageProvider : ISecureStorageProvider
} }
finally finally
{ {
FileLock.Release(); _fileLock.Release();
} }
} }
@@ -94,11 +90,12 @@ internal sealed class JsonFileStorageProvider : ISecureStorageProvider
{ {
_changeTokenRegistration?.Dispose(); _changeTokenRegistration?.Dispose();
_fileProvider?.Dispose(); _fileProvider?.Dispose();
_fileLock.Dispose();
} }
private async Task<IDictionary<string, string>> AcquireLockAndLoadAsync(CancellationToken ct) private async Task<IDictionary<string, string>> AcquireLockAndLoadAsync(CancellationToken ct)
{ {
await FileLock.WaitAsync(ct).ConfigureAwait(false); await _fileLock.WaitAsync(ct).ConfigureAwait(false);
try try
{ {
@@ -106,10 +103,16 @@ internal sealed class JsonFileStorageProvider : ISecureStorageProvider
} }
finally finally
{ {
FileLock.Release(); _fileLock.Release();
} }
} }
private async Task NotifyStorageChangedAsync()
{
await Task.Delay(250).ConfigureAwait(false);
StorageChanged?.Invoke(this, EventArgs.Empty);
}
private async Task<Dictionary<string, string>> LoadAsync(CancellationToken ct) private async Task<Dictionary<string, string>> LoadAsync(CancellationToken ct)
{ {
if (File.Exists(_options.FullPath) is false) if (File.Exists(_options.FullPath) is false)