feat(payments): integrate cancellation token in payment intent creation and update related tests

This commit is contained in:
Stevan Freeborn
2026-01-04 22:50:02 -06:00
parent 3123db088b
commit 39aec466c2
9 changed files with 85 additions and 13 deletions
+1 -1
View File
@@ -11,7 +11,7 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "tests", "tests", "{0AB3BF05
EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "GroundsForSupport.Server.Tests", "GroundsForSupport.Server.Tests", "{56565355-472A-D7A5-BBD6-5A9243A600D2}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "GroundsForSupport.API.Tests", "tests\GroundsForSupport.Server.Tests\GroundsForSupport.API.Tests.csproj", "{73D83B11-C5BC-4C4B-82BF-2DCEE689EDDC}"
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "GroundsForSupport.Server.Tests", "tests\GroundsForSupport.Server.Tests\GroundsForSupport.Server.Tests.csproj", "{73D83B11-C5BC-4C4B-82BF-2DCEE689EDDC}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
@@ -4,7 +4,7 @@ namespace GroundsForSupport.Server.Data;
internal sealed record ContextOptions
{
public string DatabaseFilePath { get; init; } = "GroundsForSupport.db";
public string DatabaseFilePath { get; init; } = string.Empty;
public string GetFullyQualifiedDatabasePath()
{
return Path.GetFullPath(DatabaseFilePath, AppContext.BaseDirectory);
@@ -16,6 +16,11 @@
<PackageReference Include="Stripe.net" Version="50.1.0" />
</ItemGroup>
<ItemGroup>
<InternalsVisibleTo Include="$(AssemblyName).Tests" />
<InternalsVisibleTo Include="DynamicProxyGenAssembly2" />
</ItemGroup>
<Target Name="InstallClientDeps" BeforeTargets="Build">
<Message Text="Installing client deps..." Importance="high" />
<Exec Command="npm install" WorkingDirectory="../GroundsForSupport.Client" />
@@ -16,7 +16,8 @@ internal static class CreatePaymentIntentEndpoint
public static async Task<IResult> CreatePaymentIntentHandler(
Request request,
IStripeService stripeService
IStripeService stripeService,
CancellationToken cancellationToken
)
{
var validationErrors = request.Validate(new ValidationContext(request));
@@ -32,7 +33,8 @@ internal static class CreatePaymentIntentEndpoint
request.Name,
request.Amount,
request.Message,
request.Email
request.Email,
cancellationToken
);
if (isSuccess is false)
@@ -6,6 +6,7 @@ internal interface IStripeService
string name,
decimal amount,
string? message,
string? email
string? email,
CancellationToken cancellationToken = default
);
}
@@ -1,5 +1,3 @@
using GroundsForSupport.Server.Data;
using Microsoft.Extensions.Options;
using Stripe;
@@ -15,7 +13,13 @@ internal sealed class StripeService(
private readonly StripeClient _client = new(options.Value.ApiKey, httpClient: new SystemNetHttpClient(httpClient));
private readonly ILogger<StripeService> _logger = logger;
public async Task<(bool IsSuccess, Intent Intent)> CreatePaymentIntentAsync(string name, decimal amount, string? message, string? email)
public async Task<(bool IsSuccess, Intent Intent)> CreatePaymentIntentAsync(
string name,
decimal amount,
string? message,
string? email,
CancellationToken cancellationToken = default
)
{
try
{
@@ -40,7 +44,7 @@ internal sealed class StripeService(
createOptions.ReceiptEmail = email;
}
var intent = await _client.V1.PaymentIntents.CreateAsync(createOptions);
var intent = await _client.V1.PaymentIntents.CreateAsync(createOptions, cancellationToken: cancellationToken);
return (true, new Intent(intent.ClientSecret));
}
@@ -4,7 +4,7 @@
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<OutputType>Exe</OutputType>
<RootNamespace>GroundsForSupport.API.Tests</RootNamespace>
<RootNamespace>GroundsForSupport.Server.Tests</RootNamespace>
<TargetFramework>net10.0</TargetFramework>
</PropertyGroup>
@@ -29,6 +29,7 @@
</PackageReference>
<PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" Version="10.0.1" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.0.1" />
<PackageReference Include="Moq" Version="4.20.72" />
<PackageReference Include="xunit.v3" Version="3.2.1" />
<PackageReference Include="xunit.runner.visualstudio" Version="3.1.5">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
@@ -1,7 +1,40 @@
using Microsoft.AspNetCore.Hosting;
using Microsoft.AspNetCore.Mvc.Testing;
using GroundsForSupport.Server.Data;
using GroundsForSupport.Server.Payments.Stripe;
namespace GroundsForSupport.API.Tests.Integration.Infra;
using System.Text.Json;
using Microsoft.Extensions.Configuration;
using System.Text;
namespace GroundsForSupport.Server.Tests.Integration.Infra;
public sealed class TestApi : WebApplicationFactory<Program>
{
protected override void ConfigureWebHost(IWebHostBuilder builder)
{
var contextOptions = new ContextOptions()
{
DatabaseFilePath = "GroundsForSupport.Test.db",
};
var stripeOptions = new StripeOptions()
{
ApiKey = "sk_test_12345",
};
var contextOptionsJson = JsonSerializer.Serialize(contextOptions);
var stripeOptionsJson = JsonSerializer.Serialize(stripeOptions);
var configJson = $@"{{
""{nameof(ContextOptions)}"": {contextOptionsJson},
""{nameof(StripeOptions)}"": {stripeOptionsJson}
}}";
var config = new ConfigurationBuilder()
.AddJsonStream(new MemoryStream(Encoding.UTF8.GetBytes(configJson)))
.Build();
builder.UseConfiguration(config);
}
}
@@ -1,7 +1,14 @@
using System.Net;
using System.Net.Http.Json;
using GroundsForSupport.API.Tests.Integration.Infra;
using GroundsForSupport.Server.Payments;
using GroundsForSupport.Server.Payments.Stripe;
using GroundsForSupport.Server.Tests.Integration.Infra;
using Microsoft.AspNetCore.TestHost;
using Microsoft.Extensions.DependencyInjection;
using Moq;
[assembly: CaptureConsole]
@@ -50,7 +57,26 @@ public sealed class PaymentTests(TestApi api) : IClassFixture<TestApi>
[Fact]
public async Task CreatePaymentIntent_WhenGivenValidRequest_ItShouldReturnCreated()
{
var client = _api.CreateClient();
var mockStripeService = new Mock<IStripeService>();
mockStripeService
.Setup(s => s.CreatePaymentIntentAsync(
It.IsAny<string>(),
It.IsAny<decimal>(),
It.IsAny<string?>(),
It.IsAny<string?>(),
It.IsAny<CancellationToken>()
)
)
.ReturnsAsync((true, new Intent("pi_12345_secret_67890")));
var api = _api.WithWebHostBuilder(
b => b.ConfigureTestServices(
s => s.AddSingleton(mockStripeService.Object)
)
);
var client = api.CreateClient();
var request = new
{