Merge pull request #20 from StevanFreeborn/stevanfreeborn/fix/pass-correct-ids-in-report-constructor

fix: make sure proper ids are passed to constructor

.github/workflows/build_publish.yml

@@ -57,7 +57,7 @@ jobs:
         with:
           token: ${{ secrets.CODECOV_TOKEN }}
       - name: Upload build artifact
-        uses: actions/upload-artifact@v3.1.2
+        uses: actions/upload-artifact@v4
         with:
           name: build
           path: ./dist

.github/workflows/lint_format_test.yaml

@@ -114,9 +114,9 @@ jobs:
           TEST_SURVEY_RECORD_ID: ${{ vars.TEST_SURVEY_RECORD_ID }}
           TEST_TEXT_FIELD: ${{ vars.TEST_TEXT_FIELD }}
       - name: Upload test coverage artifact
-        uses: actions/upload-artifact@v3.1.2
+        uses: actions/upload-artifact@v4
         with:
-          name: coverage
+          name: coverage-${{ matrix.node-version }}
           path: ./coverage
   publish_test_coverage:
     needs: test
@@ -128,7 +128,7 @@ jobs:
       - name: Download test coverage artifact
         uses: actions/download-artifact@v4.1.7
         with:
-          name: coverage
+          name: coverage-20.x
           path: ./coverage
       - name: Upload coverage reports to Codecov
         uses: codecov/codecov-action@v4

package.json

@@ -63,34 +63,34 @@
     "@commitlint/cli": "^17.8.1",
     "@commitlint/config-conventional": "^17.8.1",
     "@istanbuljs/nyc-config-typescript": "^1.0.2",
-    "@types/chai": "^4.3.16",
-    "@types/mocha": "^10.0.7",
-    "@types/node": "^18.19.41",
+    "@types/chai": "^4.3.20",
+    "@types/mocha": "^10.0.10",
+    "@types/node": "^18.19.86",
     "@types/sinon": "^10.0.20",
     "@typescript-eslint/eslint-plugin": "^5.62.0",
     "@typescript-eslint/parser": "^5.62.0",
-    "chai": "^4.4.1",
-    "dotenv": "^16.4.5",
-    "eslint": "^8.57.0",
+    "chai": "^4.5.0",
+    "dotenv": "^16.5.0",
+    "eslint": "^8.57.1",
     "eslint-config-prettier": "^8.10.0",
     "eslint-config-standard-with-typescript": "^34.0.1",
-    "eslint-plugin-import": "^2.29.1",
-    "eslint-plugin-mocha": "^10.4.3",
+    "eslint-plugin-import": "^2.31.0",
+    "eslint-plugin-mocha": "^10.5.0",
     "eslint-plugin-n": "^15.7.0",
-    "eslint-plugin-promise": "^6.4.0",
+    "eslint-plugin-promise": "^6.6.0",
     "husky": "^8.0.3",
-    "mocha": "^10.6.0",
+    "mocha": "^10.8.2",
     "nyc": "^15.1.0",
     "prettier": "^2.8.8",
     "pretty-quick": "^3.3.1",
     "sinon": "^15.2.0",
     "ts-node": "^10.9.2",
     "typedoc": "^0.25.13",
-    "typedoc-material-theme": "^1.1.0",
+    "typedoc-material-theme": "^1.4.0",
     "typescript": "^4.9.5"
   },
   "dependencies": {
-    "axios": "^1.7.4",
-    "form-data": "^4.0.0"
+    "axios": "^1.8.4",
+    "form-data": "^4.0.2"
   }
 }

src/models/ApiResponse.ts

@@ -323,7 +323,7 @@ export class ApiResponse<T> {
     const apiResponse = this as ApiResponse<any>;
 
     const reports = apiResponse.data.items.map((item: any) => {
-      return new Report(item.id, item.appId, item.name, item.description);
+      return new Report(item.appId, item.id, item.name, item.description);
     });
 
     const getPagedReportsResponse = new GetPagedReportsResponse(